Makefile of Marlin build

[martin-pr]

Hey,

There seem to be a few issues with the Makefile in the "marlin no servos" directory - it seems it was never actually used to build the firmware. The main ones are - wrong directory list, makefile failing to run copy commands because of spaces in the path, and wrong device number, not matching the one specified in the configuration header file.

Would you be interested in a patch that fixes these?

Thanks, Martin

[smartfriendz]

Hi Martin,

That sounds strange to me , as i use this directory on my computer for 3 months now ? It works very well here. Also, I know people are getting it and compile with it and i never had a complain about it.

I'm on a mac, so maybe some files are not going to github ? I've never checked by getting all from github to a new directory and try to compile .

Thank you for your proposition. It is of course very great if i can be sure everyone has a well working version.

Serge

[martin-pr]

I am on Linux, so maybe that is the difference?

It seems that the calls to $(OBJCOPY) are not in quotes, are not well escaped, and use absolute paths. Therefore, the directory name "marlin autolevel no servo" causes them to fail. Just changing the spaces to underscores "fixes" the issue.

The other problem was the line "HARDWARE_MOTHERBOARD ?= 11", which should be changed to value 33, to reflect the Configuration.h file. This file contains these lines:

#ifndef MOTHERBOARD
#define MOTHERBOARD 33
#endif

and line 336 of the Makefile contains:

CTUNING += -DMOTHERBOARD=${HARDWARE_MOTHERBOARD}

This means that the value from the Makefile will be used preferably, not the one from the Configuration.h .

The mac-specific paths are not a problem, just a small detail. I have a tendency of expecting the makefiles to work on linux as-they-are :) sorry...

Martin

[smartfriendz]

mother board=11 ? ok, i think it's really my mistake. Thank you for this feedback. I must have mixed two versions locally. If you already did the changes, i will put them on here ? thank you very much.

Serge

[martin-pr]

Yup, I'll make a pull request tonight. It is really just a few small changes.

Thanks! Martin

[smartfriendz]

Hi Martin,

Thank you . I will check that and integrate . I'm happy you did it . I was really late with all the production here.

Someone on the forum ( celljeff http://forums.reprap.org/read.php?344,383028,384311#msg-384311) did a nice implementation of XY compensation. I will try to implement it as M556 gcode like reprappro did with the omerod and like it is written in reprap.org .

I find it a good addition.

Best regards,

Serge

2014-07-15 16:09 GMT+02:00 Martin Prazak notifications@github.com:

Yup, I'll make a pull request tonight. It is really just a few small changes.

Thanks! Martin

— Reply to this email directly or view it on GitHub https://github.com/smartfriendz/smartrap/issues/5#issuecomment-49036611.

Serge Smartfriendz

Forum http://repraptalk.smartfriendz.com support Github https://github.com/smartfriendz/smartrap sources Thingiverse http://www.thingiverse.com/thing:177256 open repo