search

smartgravity / grav-theme-bones

A Grav theme built with Foundation.
MIT License
28 stars 8 forks source link

fixed URL for code-prettify #27

Closed hoalex closed 7 years ago

hoalex commented 8 years ago

The old URL was not working for me -- although the referenced file still exists, no syntax highlighting took place. I changed the URL according to the setup section here.

benblee commented 8 years ago

The url you included is simply a url to the Google Prettify repository and isn't anything that can be loaded on the site, so I'm not sure what your setup is that you were seeing the highlighting with it.

The link I have in the theme is to the CDN hosted version that does load on a site and does work. You can see it in action here:

http://demos.smartgravity.com/grav-bones/typography#code

Be sure to check that same page for how to use it as you need to put prettyprint right after the first code fence in markdown. It shows how to use the code in that example.

Feel free to open an issue if you have any other problems with the theme!

benblee commented 8 years ago

I just saw that you edited your pull request and have a new CDN entry in there!

Looks like it did change and they announced they moved to GitHub: https://code.google.com/archive/p/google-code-prettify/

I'm re-opening this and going to test it out before approving it.

Thank you for the pull request!

benblee commented 7 years ago

Fixed URL for code-prettify. Thank you @hoalex.