smartgravity / grav-theme-bones

A Grav theme built with Foundation.
MIT License
28 stars 8 forks source link

Theme modification #34

Open aleskl opened 7 years ago

aleskl commented 7 years ago

Hi, tried to modify theme using theme inheritance (as described in https://getgrav.org/blog/theme-development-with-inheritance), but when I create a child theme and activate it, I get only unstyled content, so I guess I'm missing some extra file to properly import CSS.

Cheers, Ales

ghost commented 7 years ago

I second that. I just created a whole site for a customer editing a copy of the theme. But inheriting is way cleaner and future proof.

ganar commented 7 years ago

Third time's the charm: inheritance does not work with Bones, a template that otherwise would be a great base to build on.

This problem was reported here

core77 commented 7 years ago

Hi. Bones is well done i think. The switches in the Backend are nice, to toggle specific css/js on and off.

Seems like the switches are useless, when you want do use the Foundation SCSS settings file. Because of that I'll try to start with a simple boilerplate and compile Sass files with Gulp (automatic browser reload on SCSS file and twig template changes): https://github.com/core77/grav-theme-foundation

ganar commented 7 years ago

Hi @core77: I saw the foundation theme that you referenced, but it looked that the last commit was a long time ago. Is the code of the theme up to date?

core77 commented 7 years ago

I commited yesterday.

I'm the second one, who forked the repo. Perhaps you looked at another folk's fork.

ganar commented 7 years ago

I can see that in your fork: but where are all the foundation SCSS files? which version of foundation are you using?

core77 commented 7 years ago

Doesn't make sense too keep them in the repo. There's a reference in the bower.json file.

Fire a bower install (or later bower update) and you have them in the bower_components folder.

ganar commented 7 years ago

Ah : ok. I'll try with your repo, forget about inheritance, and don't use bones. Thanks a lot for your help @core77