search

smarthomeNG / smarthome

Device integration platform for your smart home
https://www.smarthomeNG.de
GNU General Public License v3.0
119 stars 92 forks source link

docu: additional build local doc shell script working for Mac OS X #637

Closed onkelandy closed 1 month ago

msinn commented 3 months ago

What is the difference to the existing script? Could the difference be integrated in the existing script? It would be easier to maintain.

onkelandy commented 3 months ago

I have replaced all occurrences of if [ "${DOC,,}" == "all" ]; then and similar by if [ "$(echo "$DOC" | tr '[:upper:]' '[:lower:]')" == "all" ]; then

I've tested the new osx version on debian bookworm and it seems to work fine with the new code. So actually we could replace the original file if tests run smoothly for you, too..?

Morg mentioned that a cleanup might be a good idea as logics such as GIT_CHECKOUT=False if [...]; then GIT_CHECKOUT=False fi

are not clear or maybe not necessary..? Furthermore there is still a check for doc-develop and doc-user what is not necessary anymore.

onkelandy commented 1 month ago

Möchte jemand das Skript noch testen? Ich würde dann den PR schließen und einen neuen auf das normale build_doc_local stellen. Bei mir klappt das Skript sowohl unter Mac OSX als auch Debian.

bmxp commented 1 month ago

Wenn Du das integriert hast, lasse ich das mal mit meinen neueren Version von Sphinx & Co. laufen. Die neuen Sphinx Versionen haben wohl einige Bugfixes gehabt aber ich bin mir nicht wirklich sicher, ob wir alleine deshalb aktualisieren sollten.