smarthomej / addons

SmartHome/J addons for openHAB
Eclipse Public License 2.0
59 stars 23 forks source link

Sensitive data in Tuya logs #343

Closed jimtng closed 2 years ago

jimtng commented 2 years ago

I have been somewhat reluctant to post TRACE logs here because I am not sure how sensitive it is to publicly post the deviceid/productid/localkey. If such information is sensitive, would it be a good idea to mask/conceal the first N characters in the logs for ease of copy pasting.

I understand that they are needed for actual troubleshooting to match the device, etc, so perhaps it could be made a binding configuration, with the default being masked, and the ability to disable the masking? So the binding config would be something like hideLogIdChars=6 (default), and hideLogIdChars=0 to disable it.

J-N-K commented 2 years ago

That's difficult to implement and TBH I don't see much risk here. The sensitive information is your account information (username, password, access id and access secret).

If you feel more safe, replace the localKey, beside that I don't think that sensitive information is logged at all.