search

smarthomej / addons

SmartHome/J addons for openHAB
Eclipse Public License 2.0
59 stars 23 forks source link

[viessmann] fix setTargetTemperature and setCurve #398

Closed rogrun closed 1 year ago

rogrun commented 1 year ago

This PR fixes two bugs: Reported here in the community https://community.openhab.org/t/binding-smarthome-j-viessmann-binding-cant-set-value/137205

@cweitkamp: Please review these changes, thanks

Signed-off-by: Ronny Grun ronny.grun@t-online.de

cweitkamp commented 1 year ago

@rogrun Thanks for your contribution. I‘m not sure why this happened, but can you please rebase on main branch? There are some changes which do not belong here.

rogrun commented 1 year ago

@cweitkamp please review the requested changes

rogrun commented 1 year ago

@J-N-K There is another bug when setting the comfort temperature. Please wait before merging this PR.

I will report when I have finished my work.

rogrun commented 1 year ago

@cweitkamp please test and review the fix for setTemperature. Thanks.

cweitkamp commented 1 year ago

The features I am looking for are working right now. Very much appreciated. Thanks.