Background notifications for Shoryuken/ActiveJob

[Startouf]

Any hope to see some adaptation for shoryuken ? Or even better, for ActiveJob ? (and if it's supposed to be working already, I can fill out a better bug report)

[drselump14]

would love to have it

[coezbek]

It seems harder than it should be to integrate with ActiveJob.

How are others solving it:

• Good Job: https://github.com/bensheldon/good_job/issues/159
• AirBrake: https://github.com/airbrake/airbrake/blob/master/lib/airbrake/rails/active_job.rb
• DelayedJob: https://stackoverflow.com/questions/5972903/how-to-make-exceptionnotifier-work-with-delayed-job-in-rails-3

If you don't care for perfection, one way to go is to add the following to your ApplicationJob:

# app/jobs/application_job.rb
class ApplicationJob < ActiveJob::Base
  # Automatically retry jobs that encountered a deadlock
  # retry_on ActiveRecord::Deadlocked

  # Most jobs are safe to ignore if the underlying records are no longer available
  # discard_on ActiveJob::DeserializationError

  rescue_from StandardError do |exception|
    ExceptionNotifier.notify_exception(exception)
  end

end

Note: Since rescue_from stops with the first handler which handles an exception there is no way to continue with other rescue_from handlers. You could go another path with around_perform, but then all helper methods such as retry_on and discard_on will not prevent exceptions from being sent.

To decorate the failure a bit more (by giving the name of the failed job for instance) you can also do:

  rescue_from StandardError do |exception|
    begin
      raise StandardError, "#{self.class.name} failed: (#{exception.class}) #{exception}", exception.backtrace
    rescue => e
      ExceptionNotifier.notify_exception(e)
    end
  end