smartlook / cordova-smartlook

Official Smartlook SDK plugin for Cordova Android and iOS.
https://www.smartlook.com
MIT License
9 stars 6 forks source link

feat -> changed compile to implementation #35

Closed rgarciadelongoria closed 2 years ago

rgarciadelongoria commented 2 years ago

resolve issue #34

change deprecated compile to implementation

Error with compile:

Captura de Pantalla 2022-08-02 a las 11 48 30
Ziao commented 2 years ago

Can this be merged? This is working. Using your branch for now. Thanks dude <3

rgarciadelongoria commented 2 years ago

Can this be merged? This is working. Using your branch for now. Thanks dude <3

Yes dude, I use this on my own projects.

Waiting for the PR on this repo.

sneko commented 2 years ago

@SenNeonoveNoci @pavel-kroh-smartlook also thinking it should be merged :)

SenNeonoveNoci commented 2 years ago

@rgarciadelongoria @sneko @Ziao I'm so sorry that it took us this long to merge this PR. We had some changes in our team that affected this.

I have merged this and I want to ensure you that we will work on this plugin and update all the deprecated stuff in the upcoming weeks.

Thank you for your patience.

František Spurný Lead mobile developer

wsamoht commented 2 years ago

Can we get a new version tagged so this is included on npm?

UPDATE If anyone else is wondering, you can install the master branch for now until a new version is tagged.

npm install https://github.com/smartlook/cordova-smartlook#master