search

smartlook / smartlook-client

Official Smartlook client for easy frontend integration.
https://smartlook.com
MIT License
28 stars 9 forks source link

Use var instead of const #2

Closed gzzo closed 6 years ago

gzzo commented 6 years ago

Using const breaks compatibility on older IE browsers.

amertak commented 6 years ago

Hi @gzzo

Thanks for the PR. I see no problem with it, will merge it later this week.

However, I am just curious, how are you using this npm package? Webpack and other tools should be set up to convert it to ES5 thus fixing this issue automatically.

Can I ask what is your environment setup?

Thanks

gzzo commented 6 years ago

@amertak Thanks! I use this package with webpack and babel. It's common practice to exclude node_modules when using babel-loader, so this package is giving me issues. Does that help? Happy to go into more detail.

amertak commented 6 years ago

Thanks, that makes sense.

Just want to point out, that we don't officially support IE (there is a feature detection in the code). https://www.smartlook.com/help/supported-browsers/

Releasing new version to NPM.

Thanks for help!

amertak commented 6 years ago

@gzzo Published to NPM at 3.1.1

amertak commented 6 years ago

@gzzo Rewrote it to typescript, added types. Should be now better to use with package managers.