search

smartlook / smartlook-client

Official Smartlook client for easy frontend integration.
https://smartlook.com
MIT License
27 stars 9 forks source link

Console log recording freezes whole browser tab #4

Closed jakubzitny closed 4 years ago

jakubzitny commented 4 years ago

Hi,

we've recently added smartlook to our website and noticed that when we turn on the console log recording in smartool settings, smartlook freezes the whole app.

The point when this is happening is when we're initializing a pretty complicated canvas and we are printing a lot of debug/log messages in console. Not sure if the canvas or the console is the root casue, probably the console because disabling it in smartlook fixes it.

When we remove smartlook-client everything works properly.

Is there something we can do with this?

amertak commented 4 years ago

Hi, thanks for reporting the issue.

We will look into, it's possible that there is some performance bottleneck.

To help us with fixing it, can you tell us how much of the console logs do you log and how big are the data approximately? Is it happening in all browsers? Is it possible for you to show sandbox with similar code that is causing the issue or url where the issue happens?

Thanks

jakubzitny commented 4 years ago

I've tried it in our dev mode and in production mode (where not all logs are printed to console, but they exist and you guys probably touch them somehow, similarly sentry catches them as well). After the action where this problem happened, there was ~120kB of logs in just few seconds.

We'll talk in the team about sharing a sandbox version where this is reproducible, but we'd have to figure out a way and it may take some time.

And yes I've tested it in Safari and Chrome and it happened in both. My colleague tried it as well and he didn't reproduce the bug all the time, maybe 2 times out of 4.

amertak commented 4 years ago

We have done some performance improvements on the client so this issue should be fixed for now. Let us know please If it happens again. Thank you