smartlook / smartlook-mobile-issue-tracker

Official Smartlook issue tracker for mobile SDKs
4 stars 0 forks source link

Multiple crashes on Smartlook iOS SDK #124

Closed danibachar closed 2 years ago

danibachar commented 2 years ago

Platform

iOS Technology

native Build instructions [optional]

Rendering [optional]

Affected devices [optional]

Smartlook SDK version

1.8.3 Summary

Our users are suffering from different crashes on the Smartlook iOS SDK. We don't have good traces as they are hidden, but I'd love to add any kind of additional information that can help. Most of the crashes seem to be related to networking, some happen when there were no internet connection. I didn't manage to reproduce the crashes locally on my phone though

Steps to reproduce [optional]

Example Project [optional]

Relevant logs and/or screenshots

All crashes - https://ibb.co/TqPWdnq

First crash trace - https://ibb.co/zfPymZC

Second crash trace - https://ibb.co/XzVQ8SQ

Third crash trace -https://ibb.co/ScpSHRc

Forth crash trace -https://ibb.co/ScpSHRc

pavel-kroh-smartlook commented 2 years ago

Hi @danibachar , thanks for the reports.

Although the cause of the crashes is indeed no clear from the reports, we are now working on a refactoring of parts of the networking-related code (we need to improve the internal business logic there) so the next SDK version may solve this issue as well.

Crashlog symbolication is now tricky for apps that are published in bitcode form, because the app is recompiled by App Store and the standard ways of getting crash reports readable do not work anymore.

The only way seems to be to use dSYMs from App Store - Smartlook SDK includes from the version 1.8.3 the necessary mapping files for bitcode (see Acquire Updated App Symbol Information from the App Store for more details if you are interested).

There is no exact ETA for the next version, but we would like to release it sometime later in January.

Kondamon commented 2 years ago

Hello @pavel-kroh-smartlook!

I can confirm this issue

Crashed: com.apple.NSURLSession-delegate
0  Smartlook                      0x5ddec _hidden#7457_ + 346796 (__hidden#1169_:346796)
1  Smartlook                      0x5cce0 _hidden#7446_ + 342432 (__hidden#946_:342432)
2  CFNetwork                      0x1a500 CFURLRequestCopyHTTPRequestMethod + 2204
3  libdispatch.dylib              0x63194 _dispatch_call_block_and_release + 24
4  libdispatch.dylib              0x64198 _dispatch_client_callout + 16
5  libdispatch.dylib              0x3f13c _dispatch_lane_serial_drain$VARIANT$armv81 + 604
6  libdispatch.dylib              0x3fc28 _dispatch_lane_invoke$VARIANT$armv81 + 440
7  libdispatch.dylib              0x495cc _dispatch_workloop_worker_thread + 616
8  libsystem_pthread.dylib        0x4e84 _pthread_wqthread + 284
9  libsystem_pthread.dylib        0x49f0 start_wqthread + 8

I have downloaded all the dsym Files from AppStoreConnect and uploaded it to Google Firebase Crashlytics. However, I still get the "hidden" log in the crashes.

pavel-kroh-smartlook commented 2 years ago

Hi @danibachar , @Kondamon ,

new SDK version has been released.

It is a maintenance release that also aims to solve some of the crashed. Given the fact that there are ongoing issues with the crashes symbolication, we cannot guarantee we addressed all the crashes, however, we identified some patterns in them and fixed their causes.

New release version is 1.8.4, and it is available via Swift Package Manager, Cocoapods (pod Smartlook) and for direct download.

danibachar commented 2 years ago

Thanks, @pavel-kroh-smartlook - will update on the fix

pavel-kroh-smartlook commented 2 years ago

Hi @danibachar , we are closing this issue. If the crashes reemerge, feel free to reopen it or creating a new one. Thanks.