smartmicro / smartmicro_ros2_radars

ROS2 support for smartmicro radars.
Apache License 2.0
44 stars 19 forks source link

Wrong order of Point Cloud fields. #22

Closed chilisam closed 1 year ago

chilisam commented 1 year ago

In lines 96, 97 and 98 in https://github.com/smartmicro/smartmicro_ros2_radars/blob/a08720ba2294bb3271b9f24489e8adc4d14528ef/umrr_ros2_driver/src/smartmicro_radar_node.cpp#L90-L98

You have the following value order:

  1. power
  2. rcs
  3. noise

But when actually building the PCL message here:

https://github.com/smartmicro/smartmicro_ros2_radars/blob/a08720ba2294bb3271b9f24489e8adc4d14528ef/umrr_ros2_driver/src/smartmicro_radar_node.cpp#L447-L451

You have the order:

  1. rcs
  2. noise
  3. power

This applies also to all the other void SmartmicroRadarNode::targetlist_callback_*

smartSRA commented 1 year ago

Thanks for pointing this out. I am going to update this.