Closed kylerwsm closed 4 years ago
@kylerwsm When are you planning to merge this?
@mkfeuhrer I cannot merge this as I am not a maintainer of this repo. Am looking forward to get this merged too!
@ThomasEcalle Can you please review and merge this? This would be of quite some help. Thanks :)
@kylerwsm nice work! hope to see this merged soon 👍
Thanks @jamesdixon, I am still waiting on @ThomasEcalle or anyone with write access to review and merge this PR.
Does this merges?
Appriciate the work you guys doing, hope autofocus works.
So does it merged or not?
Any news here?
Sorry for the late reply. Things have gotten really busy for me recently. Will try to do up as much as possible over the weekends. If someone can help me with some of the issues pointed out by @ThomasEcalle, I will really appreciate it 🙏
还没有合并吗?
@kylerwsm Can u just merge this feature request? Or publish it to pub.dev?
dude, we need this. Show me what you got !
So the people who came back gone again.. I'd better fork this repo and maintain myself.
Thank you about your PR @kylerwsm Awesome ^^ I'm really interesting by "leading widget" but we can't merge it because comments on other features.
I think we should create a PR for each new feature, It will be easier to review to test it and to merge it. I can try to create a PR with only the "leading widget" feature. What do you think ?
Thank you again for your contribution
Thank you about your PR @kylerwsm Awesome ^^ I'm really interesting by "leading widget" but we can't merge it because comments on other features.
I think we should create a PR for each new feature, It will be easier to review to test it and to merge it. I can try to create a PR with only the "leading widget" feature. What do you think ?
Thank you again for your contribution
Sounds good to me! Sorry that I don't have the time to work on this right now
Hi all, I will be closing this PR as I do not have time to work on this right now. At the same time, I welcome anyone to pick this up.
Overview of Changes
SearchBarStyle
intoflappy_search_bar.dart
. This enables users of the search bar to useSearchBar
while defining their ownSearchBarStyle
without the need for an additional import statement.SearchBarStyle
surroundingColor
: Color of the search bar area, including the optional leading and trailing widgetssearchBarHeight
: Allows users to set the height of the search barSearchBar
centerEmptyWidget
: Whether the empty widget should be centered if shownuseCancellationWidget
: Indicates whether the user wants to use the cancellation widgetenableSuggestions
: Whether the keyboard should show dictionary suggestionssearchOnlyOnSubmit
: Whether search should only have when the searched button is pressed.contentPadding
: The padding on the searched resultleading
: Allow users to use a leading widgettrailing
: Allow users to use a trailing widgetautoFocus
: Whether the search bar should get focus on first launchfocusNode
: Allows users to use pass in their ownFocusNode
textEditingController
: Allows users to pass in their ownTextEditingController
Misc Changes
dart sdk
min version to2.3.0
to useif
statements in widgets.