smartnsoft / flappy_search_bar

SearchBar widget to handle most of search cases
MIT License
173 stars 93 forks source link

Provide more options to search bar users #16

Closed kylerwsm closed 4 years ago

kylerwsm commented 4 years ago

Overview of Changes

Misc Changes

mkfeuhrer commented 4 years ago

@kylerwsm When are you planning to merge this?

kylerwsm commented 4 years ago

@mkfeuhrer I cannot merge this as I am not a maintainer of this repo. Am looking forward to get this merged too!

mkfeuhrer commented 4 years ago

@ThomasEcalle Can you please review and merge this? This would be of quite some help. Thanks :)

jamesdixon commented 4 years ago

@kylerwsm nice work! hope to see this merged soon 👍

kylerwsm commented 4 years ago

Thanks @jamesdixon, I am still waiting on @ThomasEcalle or anyone with write access to review and merge this PR.

lucasjinreal commented 4 years ago

Does this merges?

emretuna commented 4 years ago

Appriciate the work you guys doing, hope autofocus works.

lucasjinreal commented 4 years ago

So does it merged or not?

dariof28 commented 4 years ago

Any news here?

kylerwsm commented 4 years ago

Sorry for the late reply. Things have gotten really busy for me recently. Will try to do up as much as possible over the weekends. If someone can help me with some of the issues pointed out by @ThomasEcalle, I will really appreciate it 🙏

daveleenew commented 4 years ago

还没有合并吗?

lucasjinreal commented 4 years ago

@kylerwsm Can u just merge this feature request? Or publish it to pub.dev?

danieramiz commented 4 years ago

dude, we need this. Show me what you got !

lucasjinreal commented 4 years ago

So the people who came back gone again.. I'd better fork this repo and maintain myself.

lowdev commented 4 years ago

Thank you about your PR @kylerwsm Awesome ^^ I'm really interesting by "leading widget" but we can't merge it because comments on other features.

I think we should create a PR for each new feature, It will be easier to review to test it and to merge it. I can try to create a PR with only the "leading widget" feature. What do you think ?

Thank you again for your contribution

kylerwsm commented 4 years ago

Thank you about your PR @kylerwsm Awesome ^^ I'm really interesting by "leading widget" but we can't merge it because comments on other features.

I think we should create a PR for each new feature, It will be easier to review to test it and to merge it. I can try to create a PR with only the "leading widget" feature. What do you think ?

Thank you again for your contribution

Sounds good to me! Sorry that I don't have the time to work on this right now

kylerwsm commented 4 years ago

Hi all, I will be closing this PR as I do not have time to work on this right now. At the same time, I welcome anyone to pick this up.