Changed cancel button from Text to Widget. Now it is more configurable

smartnsoft / flappy_search_bar

SearchBar widget to handle most of search cases

MIT License

172 stars 94 forks source link

Changed cancel button from Text to Widget. Now it is more configurable #4

Closed alsikorski closed 4 years ago

ThomasEcalle commented 4 years ago

Hi @AllBatros

Thank you for your feedback :) I think you are right and wee need to make the cancelation widget more configurable, great idea. But, in order to make it the more configurable possible, why not make it a simple Widget ? So the developper can do anything he wants. I think that is more Flutter philosophy.

As it is a really quick change (taking a Widget rather than Text), I have done it and it is available already with 1.7.2 version of flappy_search_bar

I hope it will help you :)

Thanks again for your help !

alsikorski commented 4 years ago

Hi,

Yes, widget is even better idea :) Thanks

BR Allbinos

pt., 24 sty 2020, 09:52 użytkownik Ecalle Thomas notifications@github.com napisał:

Closed #4 https://github.com/smartnsoft/flappy_search_bar/pull/4.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/smartnsoft/flappy_search_bar/pull/4?email_source=notifications&email_token=AEFRI5D6QOBCH4PQCQDAYF3Q7KT5TA5CNFSM4KJF74HKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWFUZC2Q#event-2976485738, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFRI5HABDY4IL6KYOY5EDTQ7KT5TANCNFSM4KJF74HA .