search

smartnsoft / flappy_search_bar

SearchBar widget to handle most of search cases
MIT License
173 stars 93 forks source link

Add better support for dark theme out of the box #7

Open QuentinSc opened 4 years ago

QuentinSc commented 4 years ago

Hello,

Very very very good work !

A very small request. Could you add support for dark theme? For the moment the font color is black on black background. Maybe use default theme text style ?

Thank you !

QuentinSc commented 4 years ago

Just remove the default value for textStyle :)

ThomasEcalle commented 4 years ago

Hi @QuentinSc First of all, I am sorry for the delay. The situation in my company (in France) with the Covid-19 has forced us to put our open source projects on the side for a moment... But I am back ! :)

I am not sure to understand your issue, as the TextStyle of hint text and text are editable with the fields hintStyle and textStyle ?

The default values are just here to show something in case you do not want to handle it, but feel free to customise it when calling the SearchBar widget :)

I'll try to be more present on this package, despite the difficult context that had lead us to change a lot the way we work here, sorry again for the delay :)

QuentinSc commented 4 years ago

Hello @ThomasEcalle (de France aussi ;-) )

It was a suggestion to make it more "plug and play" so it can use app theme without code addition. With the Light/Dark theme switcher coming back into fashion I'm strating to think like this for all my widgets.

But yes it's not a priority at all, we can close if you prefer keep your default textStyle :)

Et merci pour ce travail !