search

smartpanle / QMSD-ESP32-BSP

qmsd-esp32-bsp includes screen drivers, touch functionality, and UI framework, making it convenient for users to develop applications on the panlee development board.
MIT License
14 stars 5 forks source link

unsafe code #1

Open dannybackx opened 10 months ago

dannybackx commented 10 months ago

I have two questions really

  1. See https://github.com/espressif/esp-idf/issues/12798 the support person points to an unsafe part of your code. Note that this is in response to my report of a esp-idf-v5.2 issue - you should look into that.
  2. I note that your repository appears to have duplicates with some of the stuff in the espressif component registry, e.g. a driver for the GC9503V . Would it be a good idea to merge ? See https://components.espressif.com/components/espressif/esp_lcd_gc9503 .
EeeeBin commented 10 months ago

I apologize for the late reply. Regarding the first question, we used the driver from the Espressif repository: https://github.com/espressif/esp-iot-solution/blob/master/components/bus/8080_lcd_esp32s3.c#L350. I will contact the maintenance personnel of the Espressif IoT Solution repository to see how to fix it. As for the second question, before these drivers were available in the Espressif component registry, some optimizations had already been made here, and it is currently running stably, so there are no plans to merge them.