Accept array of objects

smartprocure / csv-generator-client

Library to generate downloadable csv files from client side data.

MIT License

6 stars 1 forks source link

Accept array of objects #18

Closed dubiousdavid closed 6 years ago

dubiousdavid commented 6 years ago

Fixes #16 Fixes #17

Accept array of objects (with column name auto-detection)
Properly quote cells, including escaping double-quotes
Some code cleanup, including removing some redundant calls.
Lots of unit-tests
Doc updates/improvements.

Tested locally on marketplace.

Required for: https://github.com/smartprocure/marketplace/pull/3832

geosp commented 6 years ago

	Warnings
:warning:	:exclamation: This PR is BIG (+383 -137) Please keep it below 500 net changes

	Messages
:book:	Your PR has no browser errors. Great job!
:book:	No `duti:fix` npm script found. Not autofixing this PR.

Generated by :no_entry_sign: dangerJS

coveralls commented 6 years ago

Coverage increased (+3.1%) to 69.792% when pulling ca46ad0dd7f706a7097e24b87ff3bfd1c40cc93a on feature/16-array-of-objects into 762ee82e9474e44b8c7d5f1fa47213ab39247131 on master.