Do not import Danger globals in the dangerfile

smartprocure / duti

Danger UTIlities

MIT License

3 stars 0 forks source link

Do not import Danger globals in the dangerfile #63

Closed stellarhoof closed 5 years ago

stellarhoof commented 5 years ago

See https://github.com/danger/danger-js/blob/master/source/danger.ts for the scoop. There's a throw there, so evaluating the dangerfile fails when running danger locally with danger ci or danger pr. This should be harmless because the dangerfile is (and should) only ever be imported by danger itself, which injects the danger global.

decrapifier commented 5 years ago

	Warnings
:warning:	The README has not been updated. Please update the README.

	Messages
:book:	Could not find any browser results.

Generated by :no_entry_sign: dangerJS against f469dfaa81d85d9b745adf7825d001edf7038267

stellarhoof commented 5 years ago

@dshishkov @Akrion I'm adding you two guys as reviewers because Daniel and David are busy and Daniel said it'd be good if more people knew about this.