search

smartprocure / duti

Danger UTIlities
MIT License
3 stars 0 forks source link

Evaluate existing danger plugins #68

Open daedalus28 opened 5 years ago

daedalus28 commented 5 years ago

There are, apparently, a fair amount of danger plugins we should check out and see if we can either collaborate with them or even deprecate some of our "duties" wholesale.

Here are a few I found:

https://github.com/nylo-andry/danger-plugin-complete-pr https://github.com/sogame/danger-plugin-toolbox https://github.com/macklinu/danger-plugin-jest

They also have a first class "plugin" approach: https://danger.systems/js/usage/extending-danger.html

It's worth evaluating if this whole repo should just be converted to danger plugins.

stellarhoof commented 5 years ago

I think it'd be easier for us to make duti itself a danger plugin a la https://github.com/sogame/danger-plugin-toolbox (a lodash-like toolbox plugin). Another option is to have npm subpackages, a disadvantage being cumbersome code reuse.

On deprecating some of our duties: I'm biased in favor of in-house code for simple stuff. The more complicated duti we've got is autoFix.js, which we should put more thought into to make it reusable and generic. testResults.js and browserResults.js seem good candidates to deprecate if we find alternatives. Even then I'd consider leaving them here. JS packages have an infamous churn-rate and the duti plugins you linked don't seem widely used, perhaps because the danger plugins api is so new.