search

smartrent / jackalope

An opinionated MQTT client library based on Tortoise MQTT
Apache License 2.0
28 stars 5 forks source link

Make :first_connect_delay and :backoff optional Jackalope options #104

Closed jfcloutier closed 3 months ago

jfcloutier commented 3 months ago

Make :first_connect_delay and :backoff true options; they need not be given but if they are they are passed to Tortoise

fhunleth commented 3 months ago

I see that :backoff applies a default here so doing the same for :first_connect_delay is consistent. However, doesn't it seem better to not copy/paste Tortoise311 default values here?

jfcloutier commented 3 months ago

I see that :backoff applies a default here so doing the same for :first_connect_delay is consistent. However, doesn't it seem better to not copy/paste Tortoise311 default values here?

I changed it to only pass the first_connect_delay option if received. To be consistent with Hubbub.

I ought to do the same for backoff. In another PR?