search

smartsdk / guided-tour

A short guide to use SmartSDK platform
6 stars 7 forks source link

Add Japanese documents #13

Closed fisuda closed 6 years ago

taliaga commented 6 years ago

Hi @fisuda thanks for this PR. Please, have a look at my comment at https://github.com/smartsdk/smartsdk-recipes/pull/44. What do you think?

fisuda commented 6 years ago

Hi @taliaga,

Sorry for the late reply. I commented at https://github.com/smartsdk/smartsdk-recipes/pull/44. Please see it.

fisuda commented 6 years ago

I removed .js and .json files. The pictures in the documents are not shown if .png files are removed. So, I kept them. Please check PR again.

taliaga commented 6 years ago

Excellent! thank you so much!

pictures in the documents are not shown if .png files are removed

To avoid duplicating the size of the repo, did you try with a sym-links to the original .png files under doc/ ?. Something like,

cd docs.ja/platform/images/
ln -s ../../../docs/platform/images/01-create-account-fiware-lab-01.png 01-create-account-fiware-lab-01.png
fisuda commented 6 years ago

Please check PR again.

taliaga commented 6 years ago

Thank you for your patience!

I won't bother you after all the translation efforts with this because it's not critical, but just for you to know, the lint job is now complaining because some lines went beyond 80 characters and some other minor details. You can check them here.

Thanks again!

fisuda commented 6 years ago

Thank you for taking your time for my PR. I will check the lint messages.