Rename method is_free_shipping()

smartsendio / woocommerce

Smart Send module for WooCommerce

GNU General Public License v3.0

0 stars 2 forks source link

Rename method is_free_shipping() #9

Closed bilfeldt closed 5 years ago

bilfeldt commented 5 years ago

We need to rename the method is_free_shipping() in the file /smart-send-logistics/includes/class-ss-shipping-wc-method.php to is_flatrate_shipping as it is no longer for free shipping, but this is a breaking change, so we will do it in 8.1 instead of in 8.0.15

bilfeldt commented 5 years ago

It is the filter woocommerce_shipping_smart_send_shipping_is_free_shipping that needs to be changed to woocommerce_shipping_smart_send_shipping_is_flat_rate_shipping.

We need to add a deprecation notice.

[x] Add new filter woocommerce_shipping_smart_send_shipping_is_free_shipping
[x] Update readme (changelog + filter documentation
[x] Add deprication notice for people still using the old filter woocommerce_shipping_smart_send_shipping_is_free_shipping

bilfeldt commented 5 years ago

Implemented