search

smartsheet-platform / smartsheet-csharp-sdk

Library that uses C# to connect to Smartsheet services.
Apache License 2.0
35 stars 30 forks source link

Double url escaping for the search api call #120

Closed thijs4ef closed 4 years ago

thijs4ef commented 4 years ago

The search api sdk action does not work properly. In the current sdk version a space will turn into %2520, it should be %20. This is happening because the search query is escaped twice.

Escaping for the search call is done in main/Smartsheet/Api/Internal/SearchResourcesImpl.cs and in smartsheet-csharp-sdk/main/Smartsheet/Api/Internal/Util/QueryUtil.cs in the current sdk.

I created a pull request which solves this issue: https://github.com/smartsheet-platform/smartsheet-csharp-sdk/pull/116 .

Thanks!

timwellswa commented 4 years ago

Fixed in 2.93.2. Thanks again for the PR.