search

smartsheet-platform / smartsheet-python-sdk

Library that uses Python to connect to Smartsheet services (using API 2.0).
Apache License 2.0
136 stars 81 forks source link

Fix bug in Python 3.10 caused by deprecation of MutableSequence in collections module #174

Closed RCoff closed 2 years ago

RCoff commented 2 years ago

Due to the deprecation of MutableSequence in the collections module in Python 3.10, the smartsheet-python-sdk package is unable to be loaded.

To fix this, I have added a try/except for loading this module.

On Python versions 2.7 up to 3.9, this will be loaded from the collections module. In Python version 3.10 and greater, this will be loaded from the collections.abc module.

RCoff commented 2 years ago

Looks as though the CI checks failed due to a missing Smartsheet Access Token.

ldacey commented 2 years ago

Any activity with this? Unfortunately this one package is the last thing preventing me from updating to 3.10 (without manually editing files or forking)

jesstucker commented 2 years ago

Yes, waiting for this PR to be approved. Who needs to merge it?

JoshRosenstein commented 2 years ago

@MatsumiyaT @timwellswa BUMP

nickgardnermedia commented 2 years ago

Any update on this by chance?

jesstucker commented 2 years ago

@timwellswa

techb0lt commented 2 years ago

I just made the changes in this PR on my virtual environment and it sure works. It will be great if this PR can be merged please.

JoshRosenstein commented 2 years ago

Emailed api@smartsheet.com . @timwellswa @MatsumiyaT