search

smartsheet / smartsheet-java-sdk

Library that uses Java to connect to Smartsheet services.
Apache License 2.0
5 stars 13 forks source link

easier fluent method chaining; AbstracttRow/Sheet made abstract; jacoco-lib upgrade; some method/test cleanup #32

Closed ronreynolds2 closed 1 year ago

ronreynolds2 commented 1 year ago

replaced AbstractRow and AbstractSheet method returns with type that the compiler can implicitly downcast to the child type (simpler code and easier fluent method chaining); AbstractRow and AbstractSheet made abstract; some stream-code added; jacoco lib upgraded to latest version (works with Java-17)

DonoA commented 1 year ago

I like this change, I wasn't aware you could use implicit generics like this. It improves code readability quite a bit.

I also think adding similar methods to getRowId and getSheetId to other models that extend IdentifiableModel would help. I will keep this in mind if I have cycles in future.