We are now down to 20 checkstyle violations in main and 0 violations in test.
The remaining 20 violations are not trivial to fix, so I've set checkstyle to allow those 20 violations to exist, but to fail the build if we ever exceed 20 violations. This should make the build fail if any new violations are added.
For tests, we do not allow any violations. This means adding a single violation will fail the build. Once the 20 violations in main are cleaned up, we can make main and test have the same config.
Note: This MR also changes our PR pipeline to run ./gradlew clean build instead of ./gradlew clean test. The reason for this is that build runs all the tests and performs all the other checks (such as checkstyle), whereas test didn't run checkstyle and we wouldn't have noticed violations until we tried to deploy.
We are now down to
20checkstyle violations in main and0violations in test.The remaining 20 violations are not trivial to fix, so I've set checkstyle to allow those 20 violations to exist, but to fail the build if we ever exceed 20 violations. This should make the build fail if any new violations are added.
For tests, we do not allow any violations. This means adding a single violation will fail the build. Once the 20 violations in main are cleaned up, we can make main and test have the same config.
Note: This MR also changes our PR pipeline to run
./gradlew clean buildinstead of./gradlew clean test. The reason for this is that build runs all the tests and performs all the other checks (such as checkstyle), whereastestdidn't run checkstyle and we wouldn't have noticed violations until we tried to deploy.