DefaultHttpClient logs entire response on Error

[zromano]

In DefaultHttpClient, we allow clients to configure what level of logging they would like to have. This helps clients from leaking sensitive PII into their logs.

However, if there is an HTTP error (non 200 code) when communicating with Smartsheet, then we log the entire response.

See the logging code below. We should not be using REQUEST_RESPONSE here.

public void logRequest(HttpRequestBase request, HttpEntitySnapshot requestEntity,
                       HttpResponse response, HttpEntitySnapshot responseEntity, long durationMillis) throws IOException {
    logger.info("{} {}, Response Code:{}, Request completed in {} ms", request.getMethod(), request.getURI(),
            response.getStatusCode(), durationMillis);
    if (response.getStatusCode() != 200) {
        // log the request and response on error
        logger.warn(LOG_ARG, RequestAndResponseData.of(request, requestEntity, response, responseEntity, REQUEST_RESPONSE));
    } else {
        // log the summary request and response on success
        logger.debug(LOG_ARG, RequestAndResponseData.of(request, requestEntity, response, responseEntity, REQUEST_RESPONSE_SUMMARY));
    }
}

Asks:

• We shouldn't add additional logging for other 200-level response code. Ex a 201 should cause us to do WARN logging
• The client should be able to configure what we log on errors

[zromano]

In my MR, I made it so we don't log any additional request/response info on a non 200 response.

The client can enable debug logging or look at the request URI that was in the info level log that still happens.

In the future if clients ask for better error logging, we can add some configurable logic in there.