Open apederson94 opened 4 months ago
Is it possible for us to add some new tests for this?
Is it possible for us to add some new tests for this?
Sure. I'm not sure what kind of tests you're looking for so if you could tell me what you're looking for, that'd be great 😄
we have Jacoco - why not make it based on a minimum test-coverage percent greater than whatever we have today? (specific to this area/new code of course).
Yeah, I was thinking some new unit tests in UserResourcesImplTest to cover these conditions.
If you run ./gradlew clean build jacocoTestReport
you'll be able to see the jacoco html report and you can see the coverage of that individual file
We could probably add a story to make it easier to see the coverage of new code
LGTM. Do we have to update any documentation anywhere to indicate that we now have support for this ?
Since this isn't a huge change to functionality but just adding a new way to call a method that already exists, I don't think we really need to do much outside of just updating the changelog. @zromano and @ronreynolds may have thoughts about this though and I would defer to their judgement
LGTM. Do we have to update any documentation anywhere to indicate that we now have support for this ?
Since this isn't a huge change to functionality but just adding a new way to call a method that already exists, I don't think we really need to do much outside of just updating the changelog. @zromano and @ronreynolds may have thoughts about this though and I would defer to their judgement
so DID the API contract change (and thus the SDK is changing to keep the client in sync with the behavior of the server)? the API documentation seems related (tho very loosely coupled) to the SDK functionality (tho having the SDK implement something NOT in the API documentation seems a bit funky IMHO).
Adds support for using listUsers with pagination. Minor refactoring work in order to clean up the way that the endpoint was being called internally. Should be more consistent now in the way things are done. Addresses #40