tweaks to build with java21 and remove finalize()

smartsheet / smartsheet-java-sdk

Library that uses Java to connect to Smartsheet services.

Apache License 2.0

3 stars 12 forks source link

tweaks to build with java21 and remove finalize() #95

Closed ronreynolds closed 3 weeks ago

ronreynolds commented 1 month ago

specific to Java-21 build (also tested with Java-11 locally):

upgrade gradle to 8.9
upgrade mockito to work with Java-21 bytecodes also
removed SmartsheetImpl.finalize() as it's deprecated and has GC impact due to requiring 2 GC passes to actually delete an object.
- added CleanerUtil to prevent this-capture in this code (javadocs in class explain what that means)
bumped the method-count to reduce check-style noise.
removed the body assertions from LoggingIT since they're no longer logged

ronreynolds commented 1 month ago

@zromano / @apederson94 i had originally intended this for release/4.0 but it should be safe for mainline. happy to update it to merge into release/4.0 instead if we want to avoid any risk. also need to create a CleanerUtilTest just to be absolutely sure the CleanerUtil code is working as intended.

ronreynolds commented 1 month ago

CleanerUtilTest added and confirmed it works as intended.

ronreynolds commented 1 month ago

@priyankalakhe unfortunately the checkstyle rules are a bit fiddly and i had to push some fresh tweaks (with no functional changes whatsoever). :-/ (and it looks like this repo is configured to reset approvals after any new push which makes total sense but is still rather inconvenient).