IntelliJ code-formatter applied to all source files; checkstyle config updates to match

smartsheet / smartsheet-java-sdk

Library that uses Java to connect to Smartsheet services.

Apache License 2.0

3 stars 12 forks source link

IntelliJ code-formatter applied to all source files; checkstyle config updates to match #97

Closed ronreynolds closed 1 day ago

ronreynolds commented 1 month ago

applied IntelliJ code-formatter to all java files (main and test)
- only required 1 rule be disabled: JavadocTagContinuationIndentation
updated checkstyle config file names to match regular names
- and thus remove customization from build.gradle
updated java.header to contain leading space indent on second line

ronreynolds commented 1 month ago

in order to verify a totally vanilla IntelliJ code-formatter config was applied i reverted my local config to default (i didn't think i had actually changed it) and then reran the formatter and one very noticeable change appeared: wildcard imports. i always disable them because i think they're evil (anti-pattern?) when it comes to code readability. somewhat conflicted whether i should leave those in or not... :-/ (checkstyle agrees with me; this rule fires ~60 times: AvoidStarImport)

zromano commented 3 weeks ago

in order to verify a totally vanilla IntelliJ code-formatter config was applied i reverted my local config to default (i didn't think i had actually changed it) and then reran the formatter and one very noticeable change appeared: wildcard imports. i always disable them because i think they're evil (anti-pattern?) when it comes to code readability. somewhat conflicted whether i should leave those in or not... :-/ (checkstyle agrees with me; this rule fires ~60 times: AvoidStarImport)

You can change this in your IntellIJ settings. I don't have a pref on this, but I know some people are anti * imports

zromano commented 2 weeks ago

I think you'll probably need to merge in the latest mainline to fix the failing tests

ronreynolds commented 2 weeks ago

I think you'll probably need to merge in the latest mainline to fix the failing tests

AFAICT it's already merged (at least according to my local git repo which i've synced with remote). checking head commit IDs... 67dfe3a appears to be HEAD on mainline and i definitely see that commit ID on this branch. will see if i can get this fixed today.

apparently the unit-test failure was caused by an issue between Halo and the Auth-service (either the Lua script or the service started failing in new ways, returning a 500 instead of a 401 if the Auth header didn't start with "Bearer"). spoke with IainW about this last week and it sounded like it was on the radar to be fixed. rerunning failed stages now. :crossed_fingers: