search

smartstore / Smartstore

A modular, scalable and ultra-fast open-source all-in-one eCommerce platform built on ASP.NET Core 7
http://www.smartstore.com/
GNU Affero General Public License v3.0
1.12k stars 411 forks source link

Make country names available for each installed language #817

Open Algorithman opened 10 months ago

Algorithman commented 10 months ago

Is your feature request related to a problem? Please describe. Countries are named differently in different languages. For example Germany (english), Allemagne (french), Deutschland (german). Nager.Country does this perfectly. They also provide a json with all translations, maybe you can get the data from there.

TLDR: Countrynames should be installed for their respective language when installing a language. This also should be applied to States/Provinces.

Algorithman commented 10 months ago

Also, all state/provinces should be in the database (since all countries are in the database).

Algorithman commented 10 months ago

Another thing I just noticed, your country data is out of date. For example the netherland antilles don't exist anymore (at least not under the country code AN/ANT) since 2010. You might want to integrate some tooling to get the newest data into your solution.

muratcakir commented 10 months ago

Nager. Country looks promising, but it doesn't contain state/region data. However, this information can be found in dr5hn countries-states-cities-database, which we can use as a sidekick (only a subset of it with the most important countries).

Algorithman commented 10 months ago

I just defaulted to Nager because I already knew it and took the states/provinces from https://github.com/stefangabos/world_countries for now to fill the database but dr5hn looks fine too. I added the states/provinces for all countries, since it's only ~3600 entries, so no real strain.