smartxworks / cluster-api-provider-elf-static-ip

1 stars 2 forks source link

Refactor releasing IP #3

Closed haijianyang closed 2 years ago

haijianyang commented 2 years ago

优化 IP 释放

之前释放 IP 和 删除 ElfMachine 是并行的,可能导致提前释放虚拟机还在使用的 IP 分配给其他的集群使用。 在删除 ElfMachine 之后再释放 IP 资源。

codecov-commenter commented 2 years ago

Codecov Report

Merging #3 (d6715cb) into main (886b294) will increase coverage by 0.51%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   72.59%   73.11%   +0.51%     
==========================================
  Files           1        1              
  Lines         208      212       +4     
==========================================
+ Hits          151      155       +4     
  Misses         39       39              
  Partials       18       18              
Impacted Files Coverage Δ
controllers/elfmachine_controller.go 73.11% <100.00%> (+0.51%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.