search

smartxworks / cluster-api-provider-elf-static-ip

1 stars 2 forks source link

SKS-1825: Remove the verification that IP must have a gateway #36

Closed haijianyang closed 8 months ago

haijianyang commented 8 months ago

Issue

ZBS CSI 的 IP Pool 可以不设置 gateway。

当前 IP Pool 没有校验是否设置了 gateway，但在分配 IP 后会校验是否有 gateway。

Change

移除分配 IP 后必须有 gateway 的校验。

Test

  1. 配置一个没有网关的 IP Pool
  2. 使用上述 IP Pool 分配给虚拟机，虚拟机被成功创建
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.40%. Comparing base (564529e) to head (b7bf934).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #36 +/- ## ========================================== + Coverage 67.53% 68.40% +0.87% ========================================== Files 2 2 Lines 308 307 -1 ========================================== + Hits 208 210 +2 + Misses 84 81 -3 Partials 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.