search

smartxworks / cluster-api-provider-virtink

Kubernetes Cluster API Provider Virtink
Apache License 2.0
25 stars 2 forks source link

test: Add controller tests #12

Closed scuzhanglei closed 2 years ago

fengye87 commented 2 years ago

Are these new test cases related to capi test infra? @scuzhanglei

scuzhanglei commented 2 years ago

Are these new test cases related to capi test infra? @scuzhanglei

nope, these test cases is for unit test. capi test infra is for e2e test, and I will add e2e test in another PR.

fengye87 commented 2 years ago

LGTM. @carezkh please take a look at this PR too.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e24c5ed). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage        ?   60.00%           
=======================================
  Files           ?        2           
  Lines           ?      285           
  Branches        ?        0           
=======================================
  Hits            ?      171           
  Misses          ?       89           
  Partials        ?       25

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.