Closed scuzhanglei closed 2 years ago
Merging #25 (40af3ae) into main (37ae04d) will decrease coverage by 1.71%. The diff coverage is 30.76%.
1.71%
30.76%
@@ Coverage Diff @@ ## main #25 +/- ## ========================================== - Coverage 52.92% 51.20% -1.72% ========================================== Files 3 3 Lines 427 496 +69 ========================================== + Hits 226 254 +28 - Misses 170 200 +30 - Partials 31 42 +11
41.63% <26.31%> (-10.89%)
53.27% <42.85%> (+7.24%)
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I'm still not sure if we should DIY IP allocation in this project. Could we pend this PR first and try the metal3's ip address manager first?
okay, I will submit another PR to compare.
new PR #28
Codecov Report
41.63% <26.31%> (-10.89%)
53.27% <42.85%> (+7.24%)
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.