search

smartxworks / virtink

Lightweight Virtualization Add-on for Kubernetes
Apache License 2.0
481 stars 37 forks source link

feat: Do not use privileged Pod #64

Closed scuzhanglei closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #64 (eec0b4f) into main (ae6d507) will increase coverage by 1.52%. The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   33.98%   35.51%   +1.52%     
==========================================
  Files           5        5              
  Lines        1439     1470      +31     
==========================================
+ Hits          489      522      +33     
+ Misses        881      878       -3     
- Partials       69       70       +1
Impacted Files Coverage Δ
pkg/controller/vm_controller.go 23.64% <37.50%> (+3.94%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

scuzhanglei commented 1 year ago

Have you tested this patch on both Kubernetes 1.24 and 1.25? KubeVirt's device plugin has some problem on 1.25

I read the KubeVirt related issue and PR, we don't have that problem, and I just tested on v1.25, it works.