search

smartxworks / virtink

Lightweight Virtualization Add-on for Kubernetes
Apache License 2.0
481 stars 37 forks source link

fix: Requeue VM with pending hotplug volumes #78

Closed scuzhanglei closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #78 (bdeac6d) into main (ca6c7cf) will increase coverage by 0.09%. The diff coverage is 5.55%.

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   34.68%   34.78%   +0.09%     
==========================================
  Files           6        6              
  Lines        1903     1912       +9     
==========================================
+ Hits          660      665       +5     
- Misses       1141     1143       +2     
- Partials      102      104       +2
Impacted Files Coverage Δ
pkg/controller/vm_controller.go 22.51% <5.55%> (+0.28%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

scuzhanglei commented 1 year ago

Have you tested on K8s without CDI installed?

virt-controller will not work. I'll try to make it be compatible with this situation.