smartxworks / virtink

Lightweight Virtualization Add-on for Kubernetes
Apache License 2.0
492 stars 41 forks source link

fix: Add timeout for calling cloud-hypervisor api #80

Closed scuzhanglei closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #80 (6b3dbdc) into main (c5bf44f) will increase coverage by 0.57%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   34.78%   35.35%   +0.57%     
==========================================
  Files           6        6              
  Lines        1912     1912              
==========================================
+ Hits          665      676      +11     
+ Misses       1143     1136       -7     
+ Partials      104      100       -4     
Impacted Files Coverage Δ
pkg/controller/vm_controller.go 23.55% <0.00%> (+1.04%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fengye87 commented 1 year ago

Will this timeout affect migration API call?

scuzhanglei commented 1 year ago

Will this timeout affect migration API call?

nope, if timeout happened would raise an error to trigger requeue