smartxworks / virtink

Lightweight Virtualization Add-on for Kubernetes
Apache License 2.0
504 stars 42 forks source link

fix: Add resource requirements for masquerade initContainers #85

Closed carezkh closed 1 year ago

carezkh commented 1 year ago

The init containers will be taken into account when determining the QoS class for the pod, without resources requirements in initContainer enable-ip-forward, the masquerade pod with cpuDedicatedPlacement will not work!

codecov[bot] commented 1 year ago

Codecov Report

Merging #85 (9e9088f) into main (8773a89) will decrease coverage by 0.02%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   34.78%   34.76%   -0.02%     
==========================================
  Files           6        6              
  Lines        1912     1913       +1     
==========================================
  Hits          665      665              
- Misses       1143     1144       +1     
  Partials      104      104              
Impacted Files Coverage Δ
pkg/controller/vm_controller.go 22.49% <0.00%> (-0.03%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.