smarty-php / smarty-lexer

Smarty 3.1 lexer / parser generator

12 stars 9 forks source link

Lexer and parser files generated not matching those in smarty-php/smarty repository #1

Open caucik opened 4 years ago

caucik commented 4 years ago

All 4 files generated using smarty-lexer differs from those shipped in smarty repository. Steps to reproduce: mkdir /tmp/smarty-test cd /tmp/smarty-test git clone https://github.com/smarty-php/smarty.git git clone https://github.com/smarty-php/smarty-lexer.git cd smarty-lexer/ php Create_Template_Parser.php php Create_Config_Parser.php

now compare .bak versions with newly generated version - for templateparser:

diff ../smarty/lexer/smarty_internal_templateparser.php.bak ../smarty/libs/sysplugins/smarty_internal_templateparser.php

same for 3 other files

wisskid commented 4 years ago

I can confirm this. As far as I can tell, the differences are codestyle related, variable declarations being moved around et cetera. But I cannot find any smarty-lexer version that matches the existing version that is in smarty now. It seems Uwe used a newer version of smarty-lexer but did not push his local changes to github. Can you confirm this, @uwetews ?

mvorisek commented 3 years ago

This should be checked in CI in smarty-php/smarty repo to prevent this happening again. PR welcome.