smarty-php / smarty

Smarty is a template engine for PHP, facilitating the separation of presentation (HTML/CSS) from application logic.
Other
2.22k stars 701 forks source link

Improvement of auto-escaping #1030

Closed Amaury closed 1 week ago

Amaury commented 1 month ago

This evolution improves the auto-escaping feature.

This Pull Request contains the source code of this evolution, as well as its documentation and unit tests.

wisskid commented 3 weeks ago

This is looking great, @Amaury !

How do you propose we release this? Do you think this calls for a new major version, i.e. Smarty v6 or a minor (v5.4)?

One might argue this requires a major, because behavior is changing for existing templates that use |escape of some form when html auto-escaping is also enabled. On the other hand: that would very likely be unintended anyway.

Amaury commented 3 weeks ago

About the release, I would say that a minor version should be enough; I don't know if anybody if really using auto-escaping and |escape at the same time. On the other hand, it's true this is a deep change of behaviour… I don't know, I let you choose ^^'

Amaury commented 1 day ago

Thank you! :)

Amaury commented 1 day ago

In the end, do you think you will create a major version or a minor one?

wisskid commented 1 day ago

I'm thinking minor.