search

smarty-php / smarty

Smarty is a template engine for PHP, facilitating the separation of presentation (HTML/CSS) from application logic.
Other
2.26k stars 712 forks source link

Add PHP 8.4 support to Smarty #1084

Closed jolelievre closed 1 day ago

jolelievre commented 1 day ago

This PR is mostly a backport of https://github.com/smarty-php/smarty/pull/1043 for version 4

This pull request updates the code base to support the deprecations introduced in PHP 8.4. It should be backwards compatible.

Updated the function signatures that had implicit null assignment to typed parameters. Added PHP 8.4 to the 'run tests'-shell script. Bumped the PHP version in the README.md

wisskid commented 1 day ago

@jolelievre couple of issues with the unit tests, I'm afraid.

jolelievre commented 1 day ago

Ok thanks @wisskid I'll look into it

jolelievre commented 1 day ago

@wisskid it should be good now, at least locally I don't have any errors anymore, I had missed some E_STRICT And I removed the \ for the Throwable

jolelievre commented 17 hours ago

Thanks @wisskid