Closed onlyjob closed 8 years ago
This package is also a dependency of gunit, which we are actively using and maintaining (instead of GoConvey). Our internal approach to dependency management is working fine with both of these projects and so we're happy with the way the dependencies are currently vendored.
My point is that even if it works for you, reinventing the wheel and fetching godeps with Makefile
does not look "fine" to me... Certainly there is a room for improvements...
And it causes some inconvenience downstream where Assertions need to be packaged as dependency of GoConvey...
It would be great if 3rd party components in
assertions/internal
could be (re-)bundled using more conventional "Godeps" system. Please remember to stick to tagged releases instead of master's head whenever possible. Thanks.