smarty / assertions

Fluent assertion-style functions used by goconvey and gunit. Can also be used in any test or application.
Other
100 stars 34 forks source link

incompatible with 1.5.1 #5

Closed charlesmata closed 8 years ago

charlesmata commented 9 years ago

seeing lots of errors when trying to build with 1.5.1 due toe internal packages not being supported in newest go version

https://groups.google.com/forum/#!topic/golang-nuts/A3KA8SNjcp0 https://docs.google.com/document/d/1e8kOo3r51b2BWtTs_1uADIA5djfXhPT36s6eHVRIvaU/edit

package . imports github.com/smartystreets/assertions/internal/oglematchers: use of internal package not allowed package ./internal/oglemock imports github.com/smartystreets/assertions/internal/oglematchers: use of internal package not allowed package ./internal/oglemock/createmock imports github.com/smartystreets/assertions/internal/oglemock/generate: use of internal package not allowed package ./internal/oglemock/generate/test_cases imports github.com/smartystreets/assertions/internal/oglemock: use of internal package not allowed package ./internal/oglemock/generate/test_cases imports github.com/smartystreets/assertions/internal/oglemock/generate/test_cases/complicated_pkg: use of internal package not allowed package ./internal/oglemock/generate/test_cases imports github.com/smartystreets/assertions/internal/oglemock/generate/test_cases/renamed_pkg: use of internal package not allowed package ./internal/oglemock/generate/test_cases/complicated_pkg imports github.com/smartystreets/assertions/internal/oglemock/generate/test_cases/renamed_pkg: use of internal package not allowed package ./internal/oglemock/sample/mock_io imports github.com/smartystreets/assertions/internal/oglemock: use of internal package not allowed package ./internal/ogletest imports github.com/smartystreets/assertions/internal/oglematchers: use of internal package not allowed package ./internal/ogletest imports github.com/smartystreets/assertions/internal/oglemock: use of internal package not allowed package ./internal/ogletest imports github.com/smartystreets/assertions/internal/ogletest/srcutil: use of internal package not allowed package ./internal/ogletest imports github.com/smartystreets/assertions/internal/reqtrace: use of internal package not allowed package ./internal/ogletest/test_cases imports github.com/smartystreets/assertions/internal/oglematchers: use of internal package not allowed package ./internal/ogletest/test_cases imports github.com/smartystreets/assertions/internal/oglemock: use of internal package not allowed package ./internal/ogletest/test_cases imports github.com/smartystreets/assertions/internal/ogletest: use of internal package not allowed package ./internal/ogletest/test_cases imports github.com/smartystreets/assertions/internal/ogletest/test_cases/mock_image: use of internal package not allowed package ./internal/ogletest/test_cases/mock_image imports github.com/smartystreets/assertions/internal/oglemock: use of internal package not allowed

mdwhatcott commented 9 years ago

Hmm, I'm confused. I thought that Go 1.5 would allow internal packages in go workspaces. Isn't that what the document you referenced states?

charlesmata commented 9 years ago

hey @mdwhatcott it seems like they removed the support for internal packages... not sure, i found the forum and it seems like i'm experiencing those same issues, and i THINK they said to move those import statements to the top of the import list. but i'm fairly new to go so i'm not sure. have you tried building this in go 1.5.1? thanks.

mdwhatcott commented 9 years ago

I'm able to build the assertions package just fine:

screen shot 2015-10-13 at 5 26 45 pm

charlesmata commented 9 years ago

hm interesting. i'll have to dig deeper then. sorry for the inconvenience! (i'm also using goop for package management, so i wonder if it's a dependency) will get back to you if i find anything substantial.