search

smarty / assertions

Fluent assertion-style functions used by goconvey and gunit. Can also be used in any test or application.
Other
100 stars 34 forks source link

Warn user when there's a subtle type diff in ShouldResemble #51

Closed srabraham closed 1 year ago

srabraham commented 1 year ago

Currently ShouldResemble fails confusingly when the visual diff of two items is the same despite DeepEquals being false.

See more context in comments in the PR, or at these issues https://github.com/smartystreets/assertions/issues/50 https://github.com/smartystreets/goconvey/issues/665

mdwhatcott commented 1 year ago

@srabraham - Thanks!

mdwhatcott commented 1 year ago

I've pushed a new release (v1.13.1) which can be incorporated by the maintainers of GoConvey.