Missing changelog entry for `smarty.com` domain name change in the SDK

smarty / changelog

Change logs for SmartyStreets software and data packages.

Other

9 stars 4 forks source link

Missing changelog entry for `smarty.com` domain name change in the SDK #3

Closed zorab47 closed 4 months ago

zorab47 commented 11 months ago

My team hit an issue when the Ruby SDK changed domain names from smartystreets.com to smarty.com, and it wasn't documented in the Ruby SDK Changelog for 5.15.1. Updating the Changelog would be helpful for others.

It included these changes, and specifically this commit: https://github.com/smartystreets/smartystreets-ruby-sdk/commit/4b3b8fac2777402cd5610a8834e2e681681bd0ca

joliver commented 11 months ago

Agreed that this should be in the SDK. I'm curious what the hit was. We still operate both domains.

zorab47 commented 11 months ago

We use VCR in our test suite and the upgrade will require re-recording all of the interactions that hit the new domain.

It was a surprise when our test suite failed during a patch semantic version change (5.15.0 to 5.15.1).