search

smarty / gunit

xUnit-style test fixture adapter for go test
Other
120 stars 11 forks source link

Fix gunit when GOPATH has multiple directories #5

Closed jmmv closed 8 years ago

jmmv commented 8 years ago

The resolveImportPath function attempts to determine the package name based on the current directory and the GOPATH setting. However, it previously assumed that GOPATH had only a single component, while it is valid for GOPATH to hold multiple directories separated by a colon.

Fix this by making resolveImportPath attempt to replace all components of GOPATH until a match is found and, if no match is found, fail with a descriptive error message. Before this, the only message the user would get was "cannot import absolute path" which does not point at the problem.

mdwhatcott commented 8 years ago

Why the change in the license file?

jmmv commented 8 years ago

Because the added code is copyrighted by Google.

mdwhatcott commented 8 years ago

Stay tuned. I'll consult with the powers that be.

jmmv commented 8 years ago

OK. I guess if you are concerned about this giving the impression that the project has changed hands, you could extend the SmartyStreets line to say "2015, 2016".

But yes, clarifying on whether you need copyright assignment (or a CLA or anything else) to accept contributions would be great. Thanks for looking into it.

mdwhatcott commented 8 years ago

After discussing this pull request with others on the team we've created a CONTRIBUTING.md file (on the master branch) to reflect our expectations with regard to open source licensing for our projects on github. Basically, any code that is submitted must abide by the existing license without modifications to the terms or copyright declaration. I hope that doesn't present an unsurmountable obstacle to submitting this code.

jmmv commented 8 years ago

Thanks for documenting your policies. I cannot submit this change based on them so I'm withdrawing it. (FWIW I found an alternative testing library, testify, which better suits my needs.)

You should consider adopting a CLA, which would give you all the protections you need to respect your license without requiring copyright assignment.