smarty / smartystreets-javascript-sdk

The official client libraries for accessing SmartyStreets APIs from javascript.
https://smartystreets.com/docs/sdk/javascript
Apache License 2.0
31 stars 30 forks source link

Recent version of axios-retry dependency breaks due to missing peerDep #38

Closed tombakerjr closed 3 years ago

tombakerjr commented 3 years ago

Version 3.2.1 of axios-retry made a breaking change that requires axios as a peerDependency. This causes the HttpSender to throw an exception when it's called e.g. in buildUsAutocompleteProClient().

https://github.com/softonic/axios-retry/blob/master/CHANGELOG.md#321---2021-10-14

tombakerjr commented 3 years ago

For anyone who stumbles onto this before a fix is out, you can add "axios-retry": "3.2.0" to your resolutionDependencies as a temporary workaround.

camiblanch commented 3 years ago

This was just published in version 1.11.2

qiquanlu commented 3 years ago

@camiblanch, I added "axios-retry": "3.2.0" yesterday and it worked with 1.11.0, but it's no longer working after your 1.11.2 release. Could you check this again? It seems axios-retry 3.2.3 still has some conflict, 3.2.0 works perfectly fine. Thanks

camiblanch commented 3 years ago

@qiquanlu I am able to replicate this issue. I am looking into switching back to 3.2.0 as you have suggested. Thank you for your patience

qiquanlu commented 3 years ago

Thank you @camiblanch I have locked our application to 1.11.0 and 3.2.0 for now, and will wait for your next release, thanks!

camiblanch commented 3 years ago

@qiquanlu Can you try out the beta version I just published? It has axios-retry at version 3.2.0.

Try npm i smartystreets-javascript-sdk@1.11.3-beta.0

camiblanch commented 3 years ago

I see it working with the beta on my end, but want to make sure it's also working for you before I publish to the "latest"

camiblanch commented 3 years ago

Just published live to 1.11.3, let me know if you are still experiencing issues after moving to that version

qiquanlu commented 3 years ago

Just published live to 1.11.3, let me know if you are still experiencing issues after moving to that version

I can confirm 1.11.3 works fine, thank you!