Open vincentdaniel opened 7 years ago
Same issue, Go 1.9 OSX.
I'm having the same issue, Go 1.9 on OS X. I had to do brew install go@1.8
and remove other versions to get my tests working again.
Goconvey relies on https://github.com/jtolds/gls for a go routine local stack to pass its context around. Only the latest version of gls works properly with 1.9. So I guess you might want to update @dannolan, @leeola , @vincentdaniel.
same here. https://github.com/jtolds/gls
at master branch 77f18212c9c7edc9bd6a33d383a7b545ce62f064
@oliveagle When dynamix told me to update, I gotbb0351aa7eb6f322f32667d51375f26a2bca6628
and it worked for me without issues.
Not countering your comment, just hoping to help - maybe the above commit will work for you?
bb0351aa7eb6f322f32667d51375f26a2bca6628
still crashes...
this is how I crash it.
import (
"github.com/stretchr/testify/assert"
"testing"
)
func TestHahah(t *testing.T) {
a := struct {Name string} {"a"}
b := struct {Name string} {"b"}
assert.Equal(t, a, b)
}
I'm having the same issue, Go 1.9 and Linux... Like @oliveagle I use stretchr's assert library
It works for me after the command below
go get -u github.com/smartystreets/goconvey
go version go1.9 darwin/amd64 / OS X 10.12.6
this solved my issue too thanks @ahdai0718
Have this issue on windows10 go 1.9 as well
If you've updated gls and you're still getting this, delete $GOPATH/pkg/linux_amd64 (or whatever your OS/arch is). I had a vendored version of gls in there in one of my projects.
Just following up as it appears this ticket is still open. This still happens, and with Go 1.10 now as well (which could be assumed as it was introduced with 1.9).
I'm running into the same issue. I tried updating both goconvey and gls but neither helped resolve the issue.
FYI: I had this issue after updating to go1.12
(out today!); I needed to govendor update github.com/jtolds/gls
before it worked again
@gedge Hitting the same problem with Golang 1.12 as well. ~Since we're using the new go modules, we can't just update gls (latest 4.20 tag is not semver format so go mod doesn't detect it)~
Edit: I was able to update gls using the branch identifier and it works: go get -u github.com/jtolds/gls@master
this does it for me using Gopkg.toml (dep)
[[override]]
name = "github.com/jtolds/gls"
revision = "b4936e06046bbecbb94cae9c18127ebe510a2cb9"
I get a panic error when I try to use goconvey with go 1.9 on linux. The same code works for version 1.8.3.
I'm using the simple example from the documentation:
With go 1.9, I get the following error:
With go 1.8.3, it works:
I'm running it on Ubuntu 16.04.3 LTS (Xenial Xerus).
Feel free to ask any additionnal information you might need to reproduce this issue.