search

smartystreets / goconvey

Go testing in the browser. Integrates with `go test`. Write behavioral tests in Go.
http://smartystreets.github.io/goconvey/
Other
8.25k stars 555 forks source link

Using a temp dir to store client resources to make coverage test work #582

Closed DeathKing closed 3 years ago

DeathKing commented 5 years ago

I had the same problem with #564 , after a simple code review, I figured out that using a temp dir to store the resources may be a solution.

Here is my quick and dirty fix. But here're few things should be noticed:

  1. Another dependency was added to copy assets directory;
  2. Code for clean temp dir was not implemented yet;

Tested in OSX/Ubuntu platform.

ps23 commented 4 years ago

Is this considered a solution then, I am not able to get coverage results see #564

gunturaf commented 4 years ago

IMO this should be a solution to #564 instead of using sudo to hack away the permission issue

mqy commented 4 years ago

This patch does not work at all: with go get or go build.

yuriy-yarosh commented 3 years ago

with go get or go build

@mqy I'll look into it today, because it looks like a viable solution. I do agree and believe that there are few missed edge cases...

Really tired that we've got no coverage reports for so long.

riannucci commented 3 years ago

Closing in favor of #618